networkx: ignore_missing_stub = false
#13968
Open
+301
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avasam
commented
May 10, 2025
Comment on lines
+41
to
+49
| # "..._DT is not present at runtime" but we don't set it in stubs, I don't understand this one | ||
| networkx(\.algorithms)?(\.tree)?(\.mst)?\.SpanningTreeIterator\.Partition\._DT | ||
| networkx(\.algorithms)?(\.tree)?(\.branchings)?\.ArborescenceIterator\.Partition\._DT | ||
|
|
||
| # variable differs from runtime type abc.ABCMeta | ||
| networkx.classes.reportviews.EdgeView.dataview | ||
| networkx.classes.reportviews.InEdgeView.dataview | ||
| networkx.classes.reportviews.OutEdgeView.dataview | ||
| networkx.classes.reportviews.OutMultiEdgeView.dataview |
There was a problem hiding this comment.
These two issues I don't understand. I'm not sure if it's something I should do differently, just ignore, and/or report to mypy/stubtest
This comment has been minimized.
This comment has been minimized.
Avasam
commented
May 10, 2025
Comment on lines
38
to
39
| # Stubtest crashes due to special unicode character | ||
| networkx.readwrite.text.* |
There was a problem hiding this comment.
I opened an issue at python/mypy#19071
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
May 10, 2025
| def items(self) -> ItemsView[str, Incomplete]: ... | ||
| def keys(self) -> KeysView[str]: ... | ||
| def values(self) -> ValuesView[Incomplete]: ... | ||
| # Our pyright test doesn't understand `requires_python` in METADATA.toml |
There was a problem hiding this comment.
I'm not too happy about this hack. Let's at least add a "TODO" comment and link a typeshed issue to fix our pyright test.
Co-authored-by: Sebastian Rittau <[email protected]>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst merging stubs from https://github.com/microsoft/python-type-stubs/tree/main/stubs/networkx , I noticed a lot of missing functions. This is a follow-up to #13956
There's 3 categories of new stubtest allowlist entries: 1 to avoid a crash, and 2 idk why they happen.