stubtest: improve handling of special dunders #9626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reckon with the fact that __init_subclass__ and __class_getitem__ are special cased to be implicit classmethods. Fix some false negatives for other special dunders.
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 22, 2020
python/mypy#9626 will make stubtest a little bit stricter about positional-only arguments for dunders like __init__
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 22, 2020
python/mypy#9626 will make stubtest a little bit stricter about positional-only arguments for dunders like __init__
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Oct 22, 2020
python/mypy#9626 will make stubtest a little bit stricter about positional-only arguments for dunders like __init__ Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reckon with the fact that init_subclass and class_getitem are
special cased to be implicit classmethods. Note this probably doesn't
fix cases where you overload, but don't mark as classmethods.
Fix some false negatives for other special dunders.