Skip to content

Fix plugin invocation for __call__ methods #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mypy/checkexpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -707,8 +707,12 @@ def check_call(self,
False, False, False, self.msg,
original_type=callee, chk=self.chk,
in_literal_context=self.is_literal_context())
callable_name = callee.type.fullname() + ".__call__"
# Apply method signature hook, if one exists
call_function = self.transform_callee_type(
callable_name, call_function, args, arg_kinds, context, arg_names, callee)
return self.check_call(call_function, args, arg_kinds, context, arg_names,
callable_node, arg_messages)
callable_node, arg_messages, callable_name, callee)
elif isinstance(callee, TypeVarType):
return self.check_call(callee.upper_bound, args, arg_kinds, context, arg_names,
callable_node, arg_messages)
Expand Down
17 changes: 17 additions & 0 deletions test-data/unit/check-custom-plugin.test
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,13 @@ class Foo:
def __setitem__(self, index: str, value: str) -> None: ...
def __iter__(self) -> Iterator[str]: ...
def __next__(self) -> str: ...
def __call__(self, *args: str) -> str: ...
def m(self, arg: str) -> str: ...

foo = Foo()
reveal_type(foo.m(2)) # E: Revealed type is 'builtins.int'
reveal_type(foo[3]) # E: Revealed type is 'builtins.int'
reveal_type(foo(4, 5, 6)) # E: Revealed type is 'builtins.int'
foo[4] = 5
for x in foo:
reveal_type(x) # E: Revealed type is 'builtins.int*'
Expand Down Expand Up @@ -536,3 +538,18 @@ func(1, 2, [3, 4], *[5, 6, 7], **{'a': 1}) # E: [[0, 0, 0, 2], [4]]
[file mypy.ini]
[[mypy]
plugins=<ROOT>/test-data/unit/plugins/arg_kinds.py

[case testHookCallableInstance]
# flags: --config-file tmp/mypy.ini
from typing import Generic, TypeVar
T = TypeVar("T")
class Class(Generic[T]):
def __init__(self, one: T): ...
def __call__(self, two: T) -> int: ...
reveal_type(Class("hi")("there")) # E: Revealed type is 'builtins.str*'
instance = Class(3.14)
reveal_type(instance(2)) # E: Revealed type is 'builtins.float*'

[file mypy.ini]
[[mypy]
plugins=<ROOT>/test-data/unit/plugins/callable_instance.py
23 changes: 23 additions & 0 deletions test-data/unit/plugins/callable_instance.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
from mypy.plugin import MethodContext, Plugin
from mypy.types import Instance, Type

class CallableInstancePlugin(Plugin):
def get_function_hook(self, fullname):
assert not fullname.endswith(' of Foo')

def get_method_hook(self, fullname):
# Ensure that all names are fully qualified
assert not fullname.endswith(' of Foo')

if fullname == '__main__.Class.__call__':
return my_hook

return None

def my_hook(ctx: MethodContext) -> Type:
if isinstance(ctx.type, Instance) and len(ctx.type.args) == 1:
return ctx.type.args[0]
return ctx.default_return_type

def plugin(version):
return CallableInstancePlugin