Allow omitting redundant Generic[T] in base classes #2811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Feb 6, 2017
|
|
||
| def get_tvars(self, tp: Type) -> List[Tuple[str, TypeVarExpr]]: | ||
| tvars = [] # type: List[Tuple[str, TypeVarExpr]] | ||
| if isinstance(tp, UnboundType): |
There was a problem hiding this comment.
Unanalyzed types can also contain TypeList instances and these should be handled here as well. For example, class A(B[Callable[[T], S]]): ... would have T inside a TypeList.
There was a problem hiding this comment.
Thank you! I forgot about TypeList, fixed this in a new commit.
|
Thanks! Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
This PR allows omitting
Generic[T, ...]if there are other generics in bases:The rules are as per PEP 484:
Generic[...]is present, then it should list all type variables (or more). In this case the order of variables is determined by their order inGeneric[...]Generic[...]in bases, then all type variables are collected in lexicographic order (i.e. by first appearance)@gvanrossum You might be interested in this.