Skip to content

Release handle on zipfile when generating path in ZipReader #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 22, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 20, 2020, 09:34

Workaround for #110

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 20, 2020, 09:53

added 1 commit

  • 2ef23f4d - Also delete references to reader in _path_from_reader

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 20, 2020, 10:12

added 1 commit

  • a9f20fe1 - Also delete the reader in _tempfile

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 20, 2020, 12:53

added 10 commits

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 11:12

added 1 commit

  • bce7564 - This approach begins to work, but it requires as_file to be aware of the internals of zipfile.Path.

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 12:58

added 1 commit

  • f077169 - Remove unnecessary context managers.

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 15:27

added 2 commits

  • a63e415 - Refactor _path_from_reader to avoid introduction of extraneous context managers.
  • b260a0b - Skip this test, because it's difficult to achieve.

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 16:39

added 3 commits

  • bdad3bb - Ignore types on compatibility objects
  • 330941f - Fix posargs for cov, diffcov
  • 38c1328 - Exclude zip files from coverage so Delete tests don't trip up coverage.

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 16:42

unmarked as a Work In Progress

@jaraco
Copy link
Member Author

jaraco commented Oct 21, 2020

In GitLab by @jaraco on Oct 21, 2020, 16:46

added 1 commit

  • cad9f27 - Consolidate import_helper functions.

Compare with previous version

@jaraco jaraco merged commit f92adfb into master Oct 22, 2020
@jaraco jaraco deleted the bugfix/bpo-41490 branch October 22, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants