-
-
Notifications
You must be signed in to change notification settings - Fork 63
move environment vars to a configuration file #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,22 @@ | |
Without any arguments builds docs for all active versions and | ||
languages. | ||
|
||
Environment variables for: | ||
- SENTRY_DSN (Error reporting) | ||
- FASTLY_SERVICE_ID/FASTLY_TOKEN (CDN purges) | ||
- PYTHON_DOCS_ENABLE_ANALYTICS (enable plausible for online docs) | ||
are read from the site configuration path for your platform | ||
(/etc/xdg/docsbuild-scripts on linux) if available, | ||
and can be overriden by writing a file to the user config dir | ||
for your platform ($HOME/.config/docsbuild-scripts on linux). | ||
The contents of the file is parsed as toml: | ||
|
||
[env] | ||
SENTRY_DSN = "https://[email protected]/69420" | ||
FASTLY_SERVICE_ID = "deadbeefdeadbeefdead" | ||
FASTLY_TOKEN = "secureme!" | ||
PYTHON_DOCS_ENABLE_ANALYTICS = "1" | ||
ewdurbin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Languages are stored in `config.toml` while versions are discovered | ||
from the devguide. | ||
|
||
|
@@ -48,6 +64,31 @@ | |
import tomlkit | ||
import urllib3 | ||
import zc.lockfile | ||
from platformdirs import user_config_path, site_config_path | ||
|
||
ENV_CONF_FILE = None | ||
_user_config_path = user_config_path("docsbuild-scripts") | ||
_site_config_path = site_config_path("docsbuild-scripts") | ||
if _user_config_path.is_file(): | ||
ENV_CONF_FILE = _user_config_path | ||
elif _site_config_path.is_file(): | ||
ENV_CONF_FILE = _site_config_path | ||
|
||
if ENV_CONF_FILE: | ||
print(f"Reading environment variables from {ENV_CONF_FILE}") | ||
if ENV_CONF_FILE == _site_config_path: | ||
print(f"You can override settings in {_user_config_path}") | ||
elif _site_config_path.is_file(): | ||
print(f"Overriding {_site_config_path}") | ||
with open(ENV_CONF_FILE, "r") as f: | ||
for key, value in tomlkit.parse(f.read()).get("env", {}).items(): | ||
print(f"Setting {key} in environment") | ||
ewdurbin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
os.environ[key] = value | ||
else: | ||
print( | ||
"No environment variables configured. " | ||
f"Configure in {_site_config_path} or {_user_config_path}" | ||
) | ||
|
||
TYPE_CHECKING = False | ||
if TYPE_CHECKING: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
jinja2 | ||
platformdirs | ||
sentry-sdk>=2 | ||
tomlkit>=0.13 | ||
urllib3>=2 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.