Skip to content

move environment vars to a configuration file #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions build_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@
Without any arguments builds docs for all active versions and
languages.

Environment variables for:
- SENTRY_DSN (Error reporting)
- FASTLY_SERVICE_ID/FASTLY_TOKEN (CDN purges)
- PYTHON_DOCS_ENABLE_ANALYTICS (enable plausible for online docs)
are read from the site configuration path for your platform
(/etc/xdg/docsbuild-scripts on linux) if available,
and can be overriden by writing a file to the user config dir
for your platform ($HOME/.config/docsbuild-scripts on linux).
The contents of the file is parsed as toml:

[env]
SENTRY_DSN = "https://[email protected]/69420"
FASTLY_SERVICE_ID = "deadbeefdeadbeefdead"
FASTLY_TOKEN = "secureme!"
PYTHON_DOCS_ENABLE_ANALYTICS = "1"

Languages are stored in `config.toml` while versions are discovered
from the devguide.

Expand Down Expand Up @@ -48,6 +64,31 @@
import tomlkit
import urllib3
import zc.lockfile
from platformdirs import user_config_path, site_config_path

ENV_CONF_FILE = None
_user_config_path = user_config_path("docsbuild-scripts")
_site_config_path = site_config_path("docsbuild-scripts")
if _user_config_path.is_file():
ENV_CONF_FILE = _user_config_path

Check warning on line 73 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L73

Added line #L73 was not covered by tests
elif _site_config_path.is_file():
ENV_CONF_FILE = _site_config_path

Check warning on line 75 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L75

Added line #L75 was not covered by tests

if ENV_CONF_FILE:
print(f"Reading environment variables from {ENV_CONF_FILE}")
if ENV_CONF_FILE == _site_config_path:
print(f"You can override settings in {_user_config_path}")
elif _site_config_path.is_file():
print(f"Overriding {_site_config_path}")
with open(ENV_CONF_FILE, "r") as f:
for key, value in tomlkit.parse(f.read()).get("env", {}).items():
print(f"Setting {key} in environment")
os.environ[key] = value

Check warning on line 86 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L78-L86

Added lines #L78 - L86 were not covered by tests
else:
print(
"No environment variables configured. "
f"Configure in {_site_config_path} or {_user_config_path}"
)

TYPE_CHECKING = False
if TYPE_CHECKING:
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
jinja2
platformdirs
sentry-sdk>=2
tomlkit>=0.13
urllib3>=2
Expand Down