Skip to content

Add ni instructions to licencing, make it more visible in quickstart #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2017
Merged

Add ni instructions to licencing, make it more visible in quickstart #151

merged 5 commits into from
Mar 21, 2017

Conversation

DimitrisJim
Copy link
Contributor

This addresses #142.

Really just added the instruction of the bot to the licencing section. Tweaked some of the wording too

I also added a note to the quick-start to make sure people actually see it. If the note seems too intrusive I can just place it at the end of the 7th list item as suggested.

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some expanding on the wording to make all the steps clear.

pullrequest.rst Outdated
homepage.
Here are the steps needed in order to sign the CLA:

1. If you don't have an account on `bugs.python.org <issue tracker>`_,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"(aka b.p.o)"

pullrequest.rst Outdated
After signing the CLA, please **wait at least one US business day** and
then check "Your Details" on `b.p.o <issue tracker>`_ to see if your account has
been marked as having signed the CLA (the delay is due to a person having
to manually check your signed CLA).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add a paragraph after this saying something about how to get the label to change. E.g.
"""
Once you have verified that your signing of the CLA has been noted on your b.p.o account, you can have the label updated by either asking for the CLA check to be run again, or the next time you make a code change to your PR.
"""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the wording a bit to make it clear that this only should be done when a PR is done and the label is added. Tell me what you think of it and if anything else needs addressing :-)

@brettcannon
Copy link
Member

If we pull this in I can link to this in the bot's comment text and keep the message really short.

@brettcannon
Copy link
Member

I went ahead and edited the PR directly, @DimitrisJim to tweak some wording to more directly consider the common case.

@brettcannon brettcannon merged commit e2f281c into python:master Mar 21, 2017
@brettcannon
Copy link
Member

Thanks, @DimitrisJim !

@DimitrisJim
Copy link
Contributor Author

Happy to have helped!

@DimitrisJim DimitrisJim deleted the fix_licencing branch March 22, 2017 16:43
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Also make the CLA more visible in the quickstart section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants