-
-
Notifications
You must be signed in to change notification settings - Fork 860
Add ni instructions to licencing, make it more visible in quickstart #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some expanding on the wording to make all the steps clear.
pullrequest.rst
Outdated
homepage. | ||
Here are the steps needed in order to sign the CLA: | ||
|
||
1. If you don't have an account on `bugs.python.org <issue tracker>`_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"(aka b.p.o)"
pullrequest.rst
Outdated
After signing the CLA, please **wait at least one US business day** and | ||
then check "Your Details" on `b.p.o <issue tracker>`_ to see if your account has | ||
been marked as having signed the CLA (the delay is due to a person having | ||
to manually check your signed CLA). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should add a paragraph after this saying something about how to get the label to change. E.g.
"""
Once you have verified that your signing of the CLA has been noted on your b.p.o account, you can have the label updated by either asking for the CLA check to be run again, or the next time you make a code change to your PR.
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the wording a bit to make it clear that this only should be done when a PR is done and the label is added. Tell me what you think of it and if anything else needs addressing :-)
If we pull this in I can link to this in the bot's comment text and keep the message really short. |
I went ahead and edited the PR directly, @DimitrisJim to tweak some wording to more directly consider the common case. |
Thanks, @DimitrisJim ! |
Happy to have helped! |
Also make the CLA more visible in the quickstart section.
This addresses #142.
Really just added the instruction of the bot to the licencing section. Tweaked some of the wording too
I also added a note to the quick-start to make sure people actually see it. If the note seems too intrusive I can just place it at the end of the 7th list item as suggested.