Update to section 12.1 #106
Conversation
I made few changes to section 12.1 as I felt appropriate, as stated in "Add tips for effective online communication to devguide #9"
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
|
I've completed the above steps |
communication.rst
Outdated
|
|
||
| - Ideas about new functionality should **not** start here and instead | ||
| - Ideas about new functionality should **NOT** start here and instead |
There was a problem hiding this comment.
Indentation is not needed here. Could you please change it to:
such as how to handle a specific issue, a PEP, etc.
- Ideas about new functionality should **not** start here and instead [...]
- Technical support questions should also not be asked [...]There was a problem hiding this comment.
If I highlight the region with grey, the hyperlinks don't work. So is it okay, if the hyperlink doesn't work? hyperlinks I'm mentioning are python-list and python-help
There was a problem hiding this comment.
Grey background is added by GitHub. I was trying to show an example in reST markup. See https://guides.github.com/features/mastering-markdown/#examples
What I was trying to say is that whitespaces in the beginning of the lines can be deleted:
Change
such as how to handle a specific issue, a PEP, etc.
- Ideas about new functionality should **not** start here and instead
should be sent to python-ideas_.to
such as how to handle a specific issue, a PEP, etc.
- Ideas about new functionality should **not** start here and instead
should be sent to python-ideas_.There was a problem hiding this comment.
Please review, was I able to do what is meant?
There was a problem hiding this comment.
LGTM. Please wait to CLA sign is checked.
communication.rst
Outdated
|
|
||
| - Ideas about new functionality should **not** start here and instead | ||
| - Ideas about new functionality should **NOT** start here and instead |
There was a problem hiding this comment.
About not -> NOT change: IMO making 'not' bold is enough.
|
Thank you for guiding me |
|
Why isn't my CLA getting signed? |
|
@nilabja10201992 Likely one of two reasons. It typically takes at least one business day for the manual approval of the CLA. The other might be that you need to put your GitHub username into your account on bugs.python.org. Please be patient. Folks have put in a lot of extra volunteer time to move the repos over to GitHub this week. Thanks ☀️ |
|
My GitHub username is registered with bugs.python.org and I've signed the CLA on Friday |
|
Thanks for the update @nilabja10201992. After someone manually review the signed CLA, you should be all set. 👍 If you don't see a change in your status by the end of Wednesday, please @ mention me and I'll look into it. I suspect the manual review is having to go through many CLAs at the moment. Thanks in advance for your patience. |
|
Okay, Thank you |
|
Since you already signed the CLA and this is a trivial change, I went ahead and merged this. Thanks! |
|
Thanks @berkerpeksag for the merge. Congrats @nilabja10201992 for the contribution. |
|
Thank you for the merge, I'm happy, I was able to contribute |
I have made few changes to section 12.1 as I felt appropriate, reference - "Add tips for effective online communication to devguide #9"