Skip to content

Quoting for config alias.pr #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terryjreedy opened this issue Jun 5, 2017 · 2 comments
Closed

Quoting for config alias.pr #217

terryjreedy opened this issue Jun 5, 2017 · 2 comments

Comments

@terryjreedy
Copy link
Member

The following in Bootcamp does not work on windows because the quoting is wrong for Windows:
git config --global alias.pr '!sh -c "git fetch upstream pull/${1}/head:pr_${1} && git checkout pr_${1}" -'
git responds with a usage message.

Windows only recognizes "..." quotes on a command line. Reversing the quotes creates the alias.
git config --global alias.pr "!sh -c 'git fetch upstream pull/${1}/head:pr_${1} && git checkout pr_${1}' -"
Subsequently, "git pr ####" works because git finds the 'sh' included with Git for Windows.

If the reversed form works on *nix, the current line can just be edited. If not, then the new line should be added with a 'for Windows' note.

@Mariatta
Copy link
Member

Mariatta commented Jun 6, 2017

hmm I tried reversing the quotes on my machine (MacOS) and it doesn't work

$ git config --global alias.pr "!sh -c 'git fetch upstream pull/${1}/head:pr_${1} && git checkout pr_${1}' -"
-bash: !sh: event not found

So we need to add a note that says "on windows, reverse the quotes" something like that?

@terryjreedy
Copy link
Member Author

"On Windows, reverse the single (') and double (") quotes." should do it.

Mariatta added a commit that referenced this issue Jun 7, 2017
On Windows, the single and double quotes should be reversed
Closes #217
Mariatta added a commit that referenced this issue Jun 7, 2017
On Windows, the single and double quotes should be reversed
Closes #217

* Clarify that the that the first git pr alias setup is for Unix /MacOS
AA-Turner pushed a commit to AA-Turner/devguide that referenced this issue Jun 17, 2022
On Windows, the single and double quotes should be reversed
Closes python#217

* Clarify that the that the first git pr alias setup is for Unix /MacOS
kitarefake added a commit to kitarefake/devguide that referenced this issue Jul 15, 2024
On Windows, the single and double quotes should be reversed
Closes python/devguide#217

* Clarify that the that the first git pr alias setup is for Unix /MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants