Skip to content

gh-99581: Fix a buffer overflow in the tokenizer when copying lines that fill the available buffer #99605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2022
Merged

gh-99581: Fix a buffer overflow in the tokenizer when copying lines that fill the available buffer #99605

merged 1 commit into from
Nov 20, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 19, 2022 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 19, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 19, 2022
Closed
@pablogsal pablogsal force-pushed the gh-99581 branch 2 times, most recently from a674cef to 45577d3 Compare November 20, 2022 00:54
@pablogsal
pythongh-99581: Fix a buffer overflow in the tokenizer when copying l…
ac5d370 
…ines that fill the available buffer

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal merged commit e13d1d9 into python:main Nov 20, 2022
@pablogsal pablogsal deleted the gh-99581 branch November 20, 2022 20:20
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @pablogsal, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e13d1d9dda8c27691180bc618bd5e9bf43dfa89f 3.11

@pablogsal pablogsal removed the needs backport to 3.11 only security fixes label Nov 20, 2022
@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e13d1d9dda8c27691180bc618bd5e9bf43dfa89f 3.10

@pablogsal pablogsal added the needs backport to 3.11 only security fixes label Nov 20, 2022
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @pablogsal, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e13d1d9dda8c27691180bc618bd5e9bf43dfa89f 3.11

@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Nov 20, 2022
@bedevere-bot
Copy link

GH-99627 is a backport of this pull request to the 3.11 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2022
@pablogsal
[3.11] pythongh-99581: Fix a buffer overflow in the tokenizer when co…
435fb16 
…pying lines that fill the available buffer (pythonGH-99605)

(cherry picked from commit e13d1d9)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Nov 20, 2022
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2022
@pablogsal @miss-islington
pythongh-99581: Fix a buffer overflow in the tokenizer when copying l…
6dd13ff 
…ines that fill the available buffer (pythonGH-99605)

(cherry picked from commit e13d1d9)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot
Copy link

GH-99628 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 20, 2022
pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2022
@pablogsal
[3.10] pythongh-99581: Fix a buffer overflow in the tokenizer when co…
94e5aa9 
…pying lines that fill the available buffer (pythonGH-99605).

(cherry picked from commit e13d1d9)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot
Copy link

GH-99630 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 20, 2022
miss-islington added a commit that referenced this pull request Nov 20, 2022
@miss-islington @pablogsal
gh-99581: Fix a buffer overflow in the tokenizer when copying lines t…
f381644 
…hat fill the available buffer (GH-99605)

(cherry picked from commit e13d1d9)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Nov 20, 2022
@pablogsal
[3.10] gh-99581: Fix a buffer overflow in the tokenizer when copying …
ad47c7d 
…lines that fill the available buffer (GH-99605). (#99630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@isidentical isidentical isidentical approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @isidentical @AlexWaygood