gh-98610: Adjust the Optional Restrictions on Subinterpreters #98618
Conversation
ericsnowcurrently
force-pushed
the
interpreter-better-restrictions
branch
from
9de6c58 to
53b5e37
Compare
|
@gpshead, we talked about this at the core sprint. |
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 77314bc 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
ericsnowcurrently
force-pushed
the
interpreter-better-restrictions
branch
2 times, most recently
from
4b8c004 to
6d62590
Compare
ericsnowcurrently
force-pushed
the
interpreter-better-restrictions
branch
from
6d62590 to
e13a305
Compare
Lib/threading.py
Outdated
| @@ -899,6 +900,8 @@ class is implemented. | |||
| self._args = args | |||
| self._kwargs = kwargs | |||
| if daemon is not None: | |||
| if daemon and not _daemon_threads_allowed(): | |||
| raise RuntimeError('daemon threads are disabled in this interpreter') | |||
There was a problem hiding this comment.
perhaps word the error message here and below as "daemon threads are disabled in this (sub)interpreter" to provide a better hint as to why.
| PyDoc_STRVAR(daemon_threads_allowed_doc, | ||
| "daemon_threads_allowed()\n\ | ||
| \n\ | ||
| Return True if daemon threads are allowed in the current interpreter,\n\ |
There was a problem hiding this comment.
Why does this need to be a function? Just to prevent people from attempting to set it?
There was a problem hiding this comment.
Daemon threads are implemented exclusively in threading.py, so we need a way to access the info from Python.
There was a problem hiding this comment.
If you mean why not an attribute, it's because I was thinking of it as an interpreter setting, rather than state of the _thread module.
| @@ -0,0 +1,5 @@ | |||
| Disallowing subprocess in subinterpreters is no longer supported. Instead, | |||
There was a problem hiding this comment.
double negative... how about wording this like
The use of the :mod:`subprocess` is now allowed from subinterpreters. Instead
:func:`os.exec` can now be disallowed. ... existing text ...
Previously, the optional restrictions on subinterpreters were: disallow fork, subprocess, and threads. By default, we were disallowing all three for "isolated" interpreters. We always allowed all three for the main interpreter and those created through the legacy
Py_NewInterpreter()API.Those settings were a bit conservative, so here we've adjusted the optional restrictions to: fork, exec, threads, and daemon threads. The default for "isolated" interpreters disables fork, exec, and daemon threads. Regular threads are allowed by default. We continue always allowing everything For the main interpreter and the legacy API.
In the code, we add
_PyInterpreterConfig.allow_execand_PyInterpreterConfig.allow_daemon_threads. We also addPy_RTFLAGS_DAEMON_THREADSandPy_RTFLAGS_EXEC.Automerge-Triggered-By: GH:ericsnowcurrently