Skip to content

gh-95853: Address wasm build and test issues (GH-95985) #95985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

gh-95853: Address wasm build and test issues (GH-95985) #95985

merged 1 commit into from
Aug 15, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 14, 2022 •
edited by bedevere-bot
Loading

  • pyexpat.c: readinst(): Use correct format char for int.
  • Add workaround for Emscripten timezone issue with calculating tm_yday.
  • Skip a decimal test that allocates a lot of memory. It sometimes fails
    on Emscripten.

@tiran
pythongh-95853: Address wasm build and test issues
91ce8dc 
- pyexpat.c: readinst(): Use correct format char for int.
- Add workaround for Emscripten timezone issue with calculating tm_yday.
- Skip a decimal test that allocates a lot of memory. It sometimes fails
  on Emscripten.
@tiran tiran marked this pull request as ready for review August 14, 2022 18:19
@tiran tiran requested a review from rhettinger as a code owner August 14, 2022 18:19
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 14, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 91ce8dc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 14, 2022
@tiran tiran changed the title gh-95853: Address wasm build and test issues gh-95853: Address wasm build and test issues (GH-95985) Aug 15, 2022
@tiran tiran merged commit 4a7f5a5 into python:main Aug 15, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-95853-2 branch August 15, 2022 05:41
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4a7f5a55dc88c14cef880ae38a96018514ca9d83 3.11

tiran added a commit to tiran/cpython that referenced this pull request Sep 11, 2022
@tiran
pythongh-95853: Address wasm build and test issues (pythonGH-95985)
1a3c5a1
tiran added a commit that referenced this pull request Sep 13, 2022
@tiran
[3.11] gh-95853: Add script to automate WASM build (GH-95828, GH-95985,
4958820 
GH-96045, GH-96389, GH-96744) (GH-96749)

Automate WASM build with a new Python script. The script provides
several build profiles with configure flags for Emscripten flavors
and WASI. The script can detect and use Emscripten SDK and WASI SDK from
default locations or env vars.

``configure`` now detects Node arguments and creates HOSTRUNNER
arguments for Node 16. It also sets correct arguments for
``wasm64-emscripten``.
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@tiran tiran

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @miss-islington @ZeroIntensity