-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-95271: Improve sqlite3 tutorial wording #95749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erlend-aasland
merged 34 commits into
python:main
from
erlend-aasland:sqlite-tutorial/improve-wording
Aug 18, 2022
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
974022c
gh-95271: Improve sqlite3 tutorial wording
erlend-aasland f21d777
Fix rest syntax
erlend-aasland 4231b75
Improve count query comment
erlend-aasland e08ca43
SQL commands => SQL queries
erlend-aasland f9a5664
Improve transaction control paragraph
erlend-aasland 484f341
Be more to the point
erlend-aasland ae0969f
Fix ref
erlend-aasland d1d11f4
Missing 'the'; even more to the point
erlend-aasland 9870036
Be more accurate
erlend-aasland 431dcb5
Remove unneeded comments; the instructions don't need to be reiterated
erlend-aasland ac7d870
Merge branch 'main' into sqlite-tutorial/improve-wording
erlend-aasland f4b66ac
Address Ezio's initial review
erlend-aasland 09ac89d
Address second round of reviews from both Ezio and CAM
erlend-aasland cbfb325
Use Python version history as example database
erlend-aasland deb199c
move sphinx comment; it creates havoc
erlend-aasland d54ff8d
Address a new round of reviews from CAM
erlend-aasland e778012
Update the example, be more explicit
erlend-aasland e9e1ffa
Address review comments
erlend-aasland f60e3a2
Missing blank line below Sphinx comment
erlend-aasland 5d03a4e
Address reviews from 2022-08-11
erlend-aasland 3ec75d1
Tone: use second person singular more often
erlend-aasland 84d798f
Adressing the last rounds of comments from CAM, Daniele, and Ezio
erlend-aasland d09d9f6
you will need to => you need to
erlend-aasland d6f4775
Address more review comments
erlend-aasland b46942b
Address CAM's last round of comments; use first person plural
erlend-aasland 4a51e1e
Typos
erlend-aasland 92fa693
Nits and a link
erlend-aasland d40c2a7
Adjust 'non-existent' example; adjust final query; sort links
erlend-aasland d2c3968
Rewrite an 'as expected'
erlend-aasland 32a19e9
Fix string format anti-pattern
erlend-aasland dd38587
Clarify how we verify that the table has been created
f41be9b
Update Doc/library/sqlite3.rst
0e0398d
Update Doc/library/sqlite3.rst
cb41c49
Revert "Update Doc/library/sqlite3.rst"
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.