Skip to content

gh-93061: Mark as artificial: backwards jump after async for #93062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2022
Merged

gh-93061: Mark as artificial: backwards jump after async for #93062

merged 2 commits into from
May 23, 2022

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented May 22, 2022 •
edited
Loading

This updates compiler_async_for to match compiler_for.

#93061

@sweeneyde sweeneyde requested a review from markshannon as a code owner May 22, 2022 02:34
@sweeneyde sweeneyde added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 22, 2022
@markshannon
Copy link
Member

Looks good. Thanks.

@markshannon markshannon merged commit a458be3 into python:main May 23, 2022
@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2022
@sweeneyde @miss-islington
pythongh-93061: Mark as artificial: backwards jump after async for (p…
d9b5fc6 
…ythonGH-93062)

(cherry picked from commit a458be3)

Co-authored-by: Dennis Sweeney <[email protected]>
@bedevere-bot
Copy link

GH-93110 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

Sorry, @sweeneyde and @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a458be3263b4cb92f3fde726461e8ef44b2a4a9d 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 23, 2022
@sweeneyde sweeneyde deleted the async_for_end_no_line branch May 23, 2022 14:48
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 23, 2022
@bedevere-bot
Copy link

GH-93120 is a backport of this pull request to the 3.10 branch.

sweeneyde added a commit that referenced this pull request May 23, 2022
@miss-islington @sweeneyde
gh-93061: Mark as artificial: backwards jump after async for (GH-93062)…
f095058 
… (GH-93110)

(cherry picked from commit a458be3)

Co-authored-by: Dennis Sweeney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@markshannon markshannon

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sweeneyde @markshannon @miss-islington @bedevere-bot