bpo-34454: datetime: Fix crash on PyUnicode_AsUTF8AndSize() failure #8850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing NULL check was reported by Svace static analyzer.
pganssle
reviewed
Aug 21, 2018
| ] | ||
|
|
||
| for sep in separators: | ||
| dt = self.theclass(2018, 1, 31, 23, 59, 47, 124789) | ||
| dtstr = dt.isoformat(sep=sep) | ||
|
|
||
| with self.subTest(dtstr=dtstr): | ||
| dt_rt = self.theclass.fromisoformat(dtstr) | ||
| try: |
There was a problem hiding this comment.
I don't think this try/catch is the right solution here. We should fix the actual problem.
serhiy-storchaka
added
type-bug
|
@taleinat Should I create another bpo for the updated PR? |
|
@izbyshev, yes, please create a new issue on bpo, with a title regarding the null dereference bugs, and mark it as a security issue. Do mention there that this bug existed and was recently fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing NULL check was reported by Svace static analyzer.
https://bugs.python.org/issue34454