[WIP] bpo-33966, multiprocessing: Fix another handle leak #7965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a pool of processes on Windows, if the worker is terminated quickly, handles created by DupHandle() on reduction.dump() can remain open in the parent process causing a handles leak. Use a different strategy in the case: keep the handle open in the parent process for the lifetime of the worker, and the parent becomes responsible to close the handle when the worker completes.
|
This change tries to fix https://bugs.python.org/issue33966 but test_wait() hangs with the change. I'm working on a different approach. |
|
I abandon this change because it changes the semantics: PR #7966 is a simpler and safer approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a pool of processes on Windows, if the worker is
terminated quickly, handles created by DupHandle() on
reduction.dump() can remain open in the parent process causing a
handles leak.
Use a different strategy in the case: keep the handle open in the
parent process for the lifetime of the worker, and the parent becomes
responsible to close the handle when the worker completes.
https://bugs.python.org/issue33966