ftplib.FTP.retrbinary callback gets a bytes, not a str #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps clarify that the callback to retrbinary gets bytes and the callback to retrlines gets str. See the tests at https://github.com/python/cpython/blob/master/Lib/test/test_ftplib.py#L558 to confirm the types that are passed to these callbacks.
|
@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @giampaolo, @benjaminp, @tiran and @vadmium to be potential reviewers. |
zhangyangyu
pushed a commit
to zhangyangyu/cpython
that referenced
this pull request
Mar 13, 2017
zhangyangyu
pushed a commit
to zhangyangyu/cpython
that referenced
this pull request
Mar 13, 2017
This was referenced Mar 13, 2017
zhangyangyu
added a commit
that referenced
this pull request
Mar 13, 2017
zhangyangyu
added a commit
that referenced
this pull request
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps clarify that the callback to retrbinary gets bytes and the callback to retrlines gets str. See the tests at https://github.com/python/cpython/blob/master/Lib/test/test_ftplib.py#L558 to confirm the types that are passed to these callbacks.