Skip to content

bpo-29768: Fixed compile-time check for expat version. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

bpo-29768: Fixed compile-time check for expat version. #574

merged 1 commit into from
Mar 9, 2017

Conversation

serhiy-storchaka
Copy link
Member

No description provided.

@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis, @akuchling, @tiran and @brettcannon to be potential reviewers.

@gpshead
Copy link
Member

gpshead commented Mar 9, 2017

The change looks fine. I do suggest double checking to confirm that XML_COMBINED_VERSION is defined in whatever the oldest version of expat we expect people to encounter is (something crazy old like RHEL/CentOS 5 era ish I'd assume).

@serhiy-storchaka
Copy link
Member Author

XML_COMBINED_VERSION is defined at the top of this file.

@serhiy-storchaka serhiy-storchaka merged commit 22e707f into python:master Mar 9, 2017
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 9, 2017
@serhiy-storchaka
bpo-29768: Fixed compile-time check for expat version. (python#574)
c3d232b 
(cherry picked from commit 22e707f)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 9, 2017
@serhiy-storchaka
bpo-29768: Fixed compile-time check for expat version. (python#574)
8489a55 
(cherry picked from commit 22e707f)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 9, 2017
@serhiy-storchaka
bpo-29768: Fixed compile-time check for expat version. (python#574)
ceaffb9 
(cherry picked from commit 22e707f)
@serhiy-storchaka serhiy-storchaka deleted the bpo-29768-check-expat-version branch March 9, 2017 08:43
serhiy-storchaka added a commit that referenced this pull request Mar 9, 2017
@serhiy-storchaka
bpo-29768: Fixed compile-time check for expat version. (#574) (#578)
952b7cb 
(cherry picked from commit 22e707f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mention-bot @gpshead @berkerpeksag @the-knights-who-say-ni