Skip to content

bpo-28856: Let %b format for bytes support objects that follow the buffer protocol #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2017

Conversation

zhangyangyu
Copy link
Member

No description provided.

@mention-bot
Copy link

@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @serhiy-storchaka, @tiran, @ethanfurman and @benjaminp to be potential reviewers.

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Mar 8, 2017
@zhangyangyu zhangyangyu requested a review from ethanfurman March 13, 2017 06:25
@serhiy-storchaka
Copy link
Member

This solution is suboptimal since it makes a copy of the buffer object. But more efficient solution may be much more complex.

@zhangyangyu
Copy link
Member Author

I agree. It may need to change the structure of the codes about bytes format. So right now I'll apply this simple way and leave a comment there.

@zhangyangyu zhangyangyu merged commit 7e2a54c into python:master Mar 14, 2017
@zhangyangyu zhangyangyu deleted the bpo-28856 branch March 14, 2017 07:07
zhangyangyu added a commit to zhangyangyu/cpython that referenced this pull request Mar 14, 2017
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.1.1 to 7.1.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@7.1.1...7.1.2)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants