bpo-28231: The zipfile module now accepts path-like objects for external paths. #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-feature
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @birkenfeld, @ezio-melotti, @Yhg1s and @ctismer to be potential reviewers. |
zhangyangyu
reviewed
Mar 8, 2017
| Open a ZIP file, where *file* can be either a path to a file (a string) or a | ||
| file-like object. The *mode* parameter should be ``'r'`` to read an existing | ||
| Open a ZIP file, where *file* can be a path to a file (a string), a | ||
| file-like object or a :term:`path-like object`. |
There was a problem hiding this comment.
file-like object is a term. So we can use :term:`file-like object`.
There was a problem hiding this comment.
Agree. But this is separate issue. There are a lot of mentions of file and file-like objects in the documentation.
zhangyangyu
approved these changes
Mar 8, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 8, 2017
…nal paths. (python#511) (cherry picked from commit 8606e95)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 16, 2017
…nal paths. (python#511) (cherry picked from commit 8606e95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.