Skip to content

make tags: index also Modules/_ctypes/ #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2017
Merged

make tags: index also Modules/_ctypes/ #4648

merged 1 commit into from
Nov 30, 2017

Conversation

vstinner
Copy link
Member

Avoid also "cd $(srcdir)" to not change the current directory.

Avoid also "cd $(srcdir)" to not change the current directory.
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@vstinner vstinner deleted the make_tags_ctypes branch November 30, 2017 21:49
@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3be3b97a9709d3cd5303175ddbffa7dcca57ac3e 3.6

@bedevere-bot
Copy link

GH-4659 is a backport of this pull request to the 3.6 branch.

vstinner added a commit that referenced this pull request Nov 30, 2017
Avoid also "cd $(srcdir)" to not change the current directory.

(cherry picked from commit 3be3b97)
vstinner added a commit that referenced this pull request Nov 30, 2017
* `make tags` fixes (GH-717)

* Fix `make tags` warnings

`make tags` target tries to find C sources and headers in "Grammar" and
"Mac" folders and generates these warnings:

    ctags: Warning: cannot open source file "Grammar/*.[ch]" : No such file or directory
    ctags: Warning: cannot open source file "Mac/*.[ch]" : No such file or directory

This commit changes $SRCDIRS variable in configure.ac to remote these
directories. This variable is used only for tags generation.

Also, "configure" was regenerated with `autoreconf`.

* Fix `make tags` fail on non-default tag names

When ctags overrides default tags filename (e.g. `-f .tags`) `make tags`
is failed because it assumes to see default `tags` filename:

    sort: cannot read: tags: No such file or directory

This commit explicitly specifies "tags" filename for tags generation.

(cherry picked from commit 8a543c0)

* make tags: index also Modules/_ctypes/ (#4648)

Avoid also "cd $(srcdir)" to not change the current directory.

(cherry picked from commit 3be3b97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants