Add missing word in docstring of assertAlmostEqual of TestCase. #3998
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Lib/unittest/case.py
Outdated
| @@ -852,7 +852,8 @@ def assertAlmostEqual(self, first, second, places=None, msg=None, | |||
| """Fail if the two objects are unequal as determined by their | |||
| difference rounded to the given number of decimal places | |||
| (default 7) and comparing to zero, or by comparing that the | |||
| between the two objects is more than the given delta. | |||
| difference between the two objects is more than the given | |||
There was a problem hiding this comment.
Thanks for the pull request @selotape!
The tests are failing because you have an extra space after the word "given".
There was a problem hiding this comment.
Thanks even more for the review @dianaclarke !
I fixed the extra space, as well as the same phrasing issue in assertNotAlmostEqual
|
Hey @dianaclarke , |
|
@selotape A core reviewer will need to add "skip news" and "skip issue" labels to resolve the bedevere issues. In the mean time, I would probably Cheers! |
…qual of TestCase.
|
@dianaclarke , I did all that locally but am afraid of force-pushing the changes. Should I open a new pull-request from another branch or just force-push? |
|
@selotape If this becomes a rabbit hole, a new pull request is always an option, but I would just force push the change (and your pull request will magically update with the rewritten history). Give that a shot first. |
selotape
force-pushed
the
documentation/unittest_assertAlmostEqual
branch
from
96162ce to
90fa3c5
Compare
|
@selotape Nice, that appears to have worked. Now we wait for a core reviewer. Rock on! |
|
GH-4039 is a backport of this pull request to the 3.6 branch. |
…trings. (pythonGH-3998) The word "difference" from missing the sentence. This clarifies that it compares the difference between the two objects. (cherry picked from commit 032a648)
…trings. (pythonGH-3998) The word "difference" from missing the sentence. This clarifies that it compares the difference between the two objects. (cherry picked from commit 032a648)
|
GH-4040 is a backport of this pull request to the 2.7 branch. |
|
Nice catch. Thanks @selotape for the PR and congrats on your first contribution to CPython 🌮 |
A minor fix to the docstring of the
assertAlmostEqualmethod ofTestCase.Added the word difference in the follwoing sentece - "... or by comparing that the difference between the two objects is more than the given delta."