Skip to content

Don't mention Guido automatically for reviews #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

brettcannon
Copy link
Member

He's written so much code he gets mentioned a lot.

He's written so much code he gets mentioned a lot.
@mention-bot
Copy link

@brettcannon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dstufft and @berkerpeksag to be potential reviewers.

@alex
Copy link
Member

alex commented Mar 1, 2017

Dumb question, what's the difference between userBlacklist and userBlacklistForPR?

@brettcannon
Copy link
Member Author

@alex According to https://github.com/facebook/mention-bot#configuration, userBlacklist means "never bother me" while userBlacklistForPR means "don't bother adding anyone if I create a PR".

@alex
Copy link
Member

alex commented Mar 1, 2017 via email

@brettcannon brettcannon merged commit 227e427 into master Mar 1, 2017
@brettcannon brettcannon deleted the brettcannon-patch-1 branch March 1, 2017 18:30
@dstufft
Copy link
Member

dstufft commented Mar 1, 2017

Yea, I was thinking about doing this anyways since it kind of defeats the purpose if the same couple of people tend to get pinged because of either being very prolific or having done some sort of mass transformation on the code base. After all, if Guido (or someone else) wants pinged on every issue they can just subscribe :)

I also suspect the quality of the data will get better now that we're on Github and author information is being correctly reflected in the commits. So it should likely get better moving forward as well.

@gvanrossum
Copy link
Member

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants