Skip to content

bpo-31234, socket.create_connection(): Fix ref cycle #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2017
Merged

bpo-31234, socket.create_connection(): Fix ref cycle #3546

merged 1 commit into from
Sep 13, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 13, 2017 •
edited by bedevere-bot
Loading

gpshead
gpshead approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rearrange the words in the comments to say "explicitly break" and "manually fixes" for correct English. Though people will understand it either way.

@vstinner vstinner merged commit acb9fa7 into python:master Sep 13, 2017
@vstinner vstinner deleted the create_connection branch September 13, 2017 17:10
@vstinner
Copy link
Member Author

Hum, for the english, I will create a different PR since I copied the comment from somewhere else.

@miss-islington
Copy link
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-3552 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2017
@vstinner @miss-islington
[3.6] bpo-31234, socket.create_connection(): Fix ref cycle (pythonGH-…
b7356f7 
…3546)

(cherry picked from commit acb9fa7)
vstinner pushed a commit that referenced this pull request Sep 13, 2017
@miss-islington @vstinner
[3.6] bpo-31234, socket.create_connection(): Fix ref cycle (GH-3546) (#…
d99e85b 
…3552)

(cherry picked from commit acb9fa7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstinner @miss-islington @bedevere-bot @gpshead @Mariatta @the-knights-who-say-ni