Skip to content

Fix stderr bug in json.tool test #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Feb 27, 2017

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick review and it looks good to me in general. I still need to test it locally.

@dhimmel
Copy link
Contributor Author

dhimmel commented Mar 6, 2017

@berkerpeksag just wanted to check in on this PR. Would love to have it merged, since the two linked pull requests are dependent on it.

@dhimmel
Copy link
Contributor Author

dhimmel commented Mar 11, 2017

@mention-bot can you mention some relevant maintainers for this PR? I don't want progress to stall.

@berkerpeksag berkerpeksag merged commit b4e9087 into python:master Mar 15, 2017
@berkerpeksag
Copy link
Member

Thanks! :)

berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Mar 15, 2017
@dhimmel dhimmel deleted the pipe-bug branch March 15, 2017 23:51
@dhimmel
Copy link
Contributor Author

dhimmel commented Mar 16, 2017

3.6 backport pull request is #676 (I guess GitHub doesn't automatically cross-reference issues in pull request titles).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants