bpo-47151: Fallback to fork when vfork fails in subprocess. #32186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
added
type-bug
vstinner
reviewed
Mar 30, 2022
vstinner
reviewed
Mar 30, 2022
vstinner
reviewed
Mar 31, 2022
raghavthind2005
approved these changes
Mar 31, 2022
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @gpshead, I could not cleanly backport this to |
|
GH-32219 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 31, 2022
…-32186) bpo-47151: Fallback to fork when vfork fails in subprocess. An OS kernel can specifically decide to disallow vfork() in a process. No need for that to prevent us from launching subprocesses. (cherry picked from commit 4a08c4c) Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 31, 2022
bpo-47151: Fallback to fork when vfork fails in subprocess. An OS kernel can specifically decide to disallow vfork() in a process. No need for that to prevent us from launching subprocesses. (cherry picked from commit 4a08c4c) Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vfork()can return -1 and seterrno. We now fall back tofork()in that situation as one possible error isEINVALindicating that the kernel doesn't permit vfork from the current process. See the bug.https://bugs.python.org/issue47151