-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-30824: Add .json mimetype #3048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
906f941
to
ba965f8
Compare
Sorry about all the redundant approvals, @e4r7hbug , but your PR was simple enough that I could make sure the PR wasn't wasted by me approving it and I needed to test something (the new "awaiting merge" label 😄 ). |
Is backporting done automatically or is a new PR necessary? |
New PRs are necessary. Not sure if @bitdancer was planning to do that still, although if you want to do it, @sijis, I'm sure he wouldn't mind the help. 😄 |
Yeah, I'd love to try. |
@sijis then go for it! Have a look at https://github.com/python/core-workflow/tree/master/cherry_picker as that's what we use to create backport PRs (there will also be details in the devguide). The key thing, though, is getting the title formatted properly as we have webhooks in GitHub to connect the backport PRs back to this PR and remove the "backport" labels automatically. |
🐍🍒⛏🤖 Thanks @e4r7hbug for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6. |
GH-3394 is a backport of this pull request to the 2.7 branch. |
(cherry picked from commit 8204b90)
🐍🍒⛏🤖 Thanks @e4r7hbug for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 3.6. |
(cherry picked from commit 8204b90)
GH-3401 is a backport of this pull request to the 3.6 branch. |
The
.json
extension should have a recognized mimetype as registered by the IANA.See discussion: https://mail.python.org/pipermail/python-ideas/2017-August/046666.html
https://bugs.python.org/issue30824