Skip to content

bpo-46269: remove special-casing of __new__ in Enum.__dir__ #30421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

bpo-46269: remove special-casing of __new__ in Enum.__dir__ #30421

merged 1 commit into from
Jan 5, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 5, 2022 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from ethanfurman as a code owner January 5, 2022 15:17
AlexWaygood
AlexWaygood approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love it if we could find some way of getting user-overridden __new__ methods to show up in the output of dir() and help(), but this is definitely better than the current, broken code -- thanks!

@ethanfurman ethanfurman merged commit 817a6bc into python:main Jan 5, 2022
@ethanfurman
Copy link
Member

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @ethanfurman @AlexWaygood @the-knights-who-say-ni @bedevere-bot