bpo-46008: Move Py*State init into distinct functions. #29977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 7b376d4 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently basic initialization of
PyInterprterStatehappens inPyInterpreterState_New()(along with allocation and adding the new interpreter to the runtime state). This prevents us from initializing interpreter states that were allocated separately (e.g. statically or in a free list). We address that here by factoring out a separate function just for initialization. We do the same forPyThreadState._PyRuntimeStatewas sorted out when we added it since_PyRuntimeis statically allocated. However, in this PR we update the existing init code to line up with the functions forPyInterpreterStateandPyThreadState.(There should be zero change in behavior.)
https://bugs.python.org/issue46008