[3.9] bpo-45866: pegen strips directory of "generated from" header (GH-29777) (GH-29792) #29797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Nov 26, 2021
| @@ -0,0 +1,4 @@ | |||
| ``make regen-all`` now produces the same output when run from a directory | |||
| other than the source tree: when building Python out of the source tree. | |||
| pegen now strips directory of the "generated by pygen from <FILENAME" header | |||
There was a problem hiding this comment.
Suggested change
| pegen now strips directory of the "generated by pygen from <FILENAME" header | |
| pegen now strips directory of the "generated by pygen from <FILENAME>" header |
There was a problem hiding this comment.
Oh, that's a backport of a change which already landed in main and 3.10 branches :-( I prefer to keep the typo. The typo can be fixed in a separated PR, but I'm not really motivated to write a PR just for that :-p
There was a problem hiding this comment.
Well, I created PR to fix this important typo :-) https://github.com/python/cpython/pull/29798/files
cc @hroncok
hroncok
reviewed
Nov 26, 2021
| @@ -0,0 +1,4 @@ | |||
| ``make regen-all`` now produces the same output when run from a directory | |||
| other than the source tree: when building Python out of the source tree. | |||
| pegen now strips directory of the "generated by pygen from <FILENAME" header | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make regen-all" now produces the same output when run from a
directory other than the source tree: when building Python out of the
source tree.
(cherry picked from commit 253b7a0)
(cherry picked from commit b6defde)
https://bugs.python.org/issue45866