-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-45878: convert try/except
to self.assertRaises
in Lib/ctypes/test/test_functions.py
#29721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/test/test_functions.py`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be reasons of using try/except instead of assertRaises() (the latter affects exception chaining and other subtle details), but in in this case using assertRaises() is correct and beneficial. It is not pure cosmetic change.
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
…/test/test_functions.py` (pythonGH-29721) (cherry picked from commit b48ac6f) Co-authored-by: Nikita Sobolev <[email protected]>
GH-29722 is a backport of this pull request to the 3.10 branch. |
…/test/test_functions.py` (pythonGH-29721) (cherry picked from commit b48ac6f) Co-authored-by: Nikita Sobolev <[email protected]>
GH-29723 is a backport of this pull request to the 3.9 branch. |
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-29748 is a backport of this pull request to the 3.10 branch. |
…/test/test_functions.py` (pythonGH-29721) (cherry picked from commit b48ac6f) Co-authored-by: Nikita Sobolev <[email protected]>
…/test/test_functions.py` (pythonGH-29721)
…/test/test_functions.py` (GH-29721) (GH-29723) (cherry picked from commit b48ac6f) Co-authored-by: Nikita Sobolev <[email protected]>
…/test/test_functions.py` (GH-29721) (GH-29748) (cherry picked from commit b48ac6f) Co-authored-by: Nikita Sobolev <[email protected]>
https://bugs.python.org/issue45878