bpo-31034: Reliable signal handler for test_asyncio #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on the current SIGHUP signal handler, make sure that it's set to the "default" signal handler: SIG_DFL.
brettcannon
changed the title
brettcannon
changed the title
brettcannon
changed the title
brettcannon
changed the title
|
Sorry about the title change noise: trying to figure out why this PR wasn't editable. |
|
It's editable now 👍 |
Did it do something wrong? |
|
@Haypo yep, we ran into a bug in GitHub's API that was automatically turning off the ability to edit PRs by project maintainers. New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀 |
|
"New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀" Oh ok, no problem. It seems like at the end, it works, nice ;-) |
|
GH-2876 is a backport of this pull request to the 3.6 branch. |
vstinner
added a commit
that referenced
this pull request
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.
https://bugs.python.org/issue31034