bpo-30993: IDLE - Improve configdialog font page and tests. #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terryjreedy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @csabella, @kbkaiser and @zooba to be potential reviewers. |
|
screwed up, will try again |
* Document causal pathways in docstring. * Simplify some attribute names. * Rename test_bold_toggle_set_samples to make test_font_set fail. * Fix test_font_set so not order dependent. * Fix renamed test_indent_scale so it tests the widget.
terryjreedy
changed the title
csabella
reviewed
Jul 22, 2017
| d = dialog | ||
| d.font_name.set('Test Font') | ||
| d.font_size.set(default_size) | ||
| d.font_bold.set(default_bold) |
There was a problem hiding this comment.
I was wondering - if you add a similar test as bold_toggle for the sizelist selection, maybe the initialization of the 3 Tk variables should be in setUp()? That would mean that all the tests start with the same values (presumably from GetFont), but the bold_toggle test is a lot different than that now. font_size 5 in that test isn't even on the menu for size, so it would be an invalid value there.
terryjreedy
added a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 23, 2017
…thonGH-2818) * Document causal event pathways in docstring. * Simplify some attribute names. * Rename test_bold_toggle_set_samples to make test_font_set fail. * Fix test_font_set so not order dependent. * Fix renamed test_indent_scale so it tests the widget. (cherry picked from commit 07ba305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30993