Skip to content

[3.6] bpo-30981: IDLE -- Add more configdialog font page tests. (GH-… #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2017

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jul 21, 2017

…2794)

(cherry picked from commit d0969d6)

https://bugs.python.org/issue30981

@terryjreedy
Copy link
Member Author

Appveyor test failed with

"Traceback (most recent call last):
File "C:\projects\cpython\lib\idlelib\idle_test\test_configdialog.py", line 79, in test_bold_toggle
d.bold_toggle.toggle()
AttributeError: 'ConfigDialog' object has no attribute 'bold_toggle'"

Indeed it does not, as I forgot to add 'self.' in front of of the definition to save the reference. How did this pass travis -- by not runnig gui tests. Easy fix for3.7 first, but exposes another problem.

"FAIL: test_set_samples (idlelib.idle_test.test_configdialog.FontTabTest)

Traceback (most recent call last):
File "C:\projects\cpython\lib\idlelib\idle_test\test_configdialog.py", line 90, in test_set_samples
self.assertTrue(d.font_sample == d.highlight_sample == expected)
AssertionError: False is not true"

This might be an issue with the number 5 versus string '5', but should not be different on Win7.

I disabled test class on master until I fix it properly.

@terryjreedy
Copy link
Member Author

terryjreedy commented Jul 22, 2017

Add to message:
Verify that clicking the bold checkbutton and calling its command, set_samples, changes the bold setting of both samples. Simplify some names in configdialog.

Incorporates changes and fixes from PRs 2798 and 2810.

@terryjreedy terryjreedy merged commit 04864b4 into python:3.6 Jul 22, 2017
@terryjreedy terryjreedy deleted the backport-d0969d6-3.6 branch July 22, 2017 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants