bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. #26808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
approved these changes
Jun 22, 2021
|
Thanks @freakboy3742 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26844 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 22, 2021
…ythonGH-26808) * bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. (cherry picked from commit 92c2e91) Co-authored-by: Russell Keith-Magee <[email protected]>
gpshead
pushed a commit
that referenced
this pull request
Jun 22, 2021
…H-26808) (GH-26844) * bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. (cherry picked from commit 92c2e91) Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the declaration of
BUFFER_BLOCK_SIZEto be static, so that if multiple modules include thepycore_blocks_output_buffer.hheader file, the resulting Python executable is able to link.Without this declaration, if two or more of the bz2, lzma or zlib modules are compiled as statically linked modules (i.e., added to Lib/Setup.local), linking the Python executable results in a duplicate symbol error:
https://bugs.python.org/issue44458