bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly #26764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong.
serhiy-storchaka
added
needs backport to 3.9
|
Thanks @animalize for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
Sorry, @animalize and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-26845 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 22, 2021
…correctly (pythonGH-26764) No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong. (cherry picked from commit bc6c12c) Co-authored-by: Ma Lin <[email protected]>
ghost
deleted the
ghost
mentioned this pull request
|
|
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 22, 2021
…correctly (GH-26764) (GH-26845) No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong. (cherry picked from commit bc6c12c) Co-authored-by: Ma Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying C codes handle buffer protocol objects correctly, so only fix the wrong length in Python code is fine.
https://bugs.python.org/issue44439