Skip to content

bpo-14322: added test case for invalid update to hmac #26636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2024
Merged

bpo-14322: added test case for invalid update to hmac #26636

merged 3 commits into from
Feb 25, 2024

Conversation

CCLDArjun
Copy link
Contributor

@CCLDArjun CCLDArjun commented Jun 10, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 10, 2021
nanjekyejoannah
nanjekyejoannah reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have to create a new test class with just one test?

Why do I think this test could live under class TestVectorsTestCase, there seem to be many cases exercising update or am I missing something?

@CCLDArjun
Copy link
Contributor Author

@nanjekyejoannah
I was going to add it to TestVectorsTestCase but I wasn't sure it belonged there. It seems those tests are to check the accuracy of the hash digests?

There are indeed other tests testing the update function, but I'm adding a test to check if there is an Error raised for invalid inputs to the function (i.e. anything other than bytes object)

nanjekyejoannah
nanjekyejoannah reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you comment on bpo, to solicit ideas from others on a better place, I may also be eluded.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 11, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2022
@CCLDArjun CCLDArjun closed this Jul 12, 2023
@packetslave packetslave mannequin mentioned this pull request Jan 5, 2024
Closed
@hugovk hugovk reopened this Feb 24, 2024
@hugovk
Copy link
Member

hugovk commented Feb 24, 2024

I think a new test case is fine, TestVectorsTestCase is doing something else, and no-one replied on the issue.

Let's re-open, update and retest.

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 25, 2024
@hugovk hugovk merged commit 6550b54 into python:main Feb 25, 2024
@miss-islington-app
Copy link

Thanks @CCLDArjun for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2024
@CCLDArjun @hugovk @miss-islington
bpo-14322: added test case for invalid update to hmac (pythonGH-26636)
ac94c18 
(cherry picked from commit 6550b54)

Co-authored-by: Arjun <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
Copy link
Member

hugovk commented Feb 25, 2024

Thank you for the PR!

@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2024

GH-115904 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2024
@CCLDArjun @hugovk @miss-islington
bpo-14322: added test case for invalid update to hmac (pythonGH-26636)
ef7e6f5 
(cherry picked from commit 6550b54)

Co-authored-by: Arjun <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2024

GH-115905 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 25, 2024
hugovk added a commit that referenced this pull request Feb 25, 2024
@miss-islington @CCLDArjun @hugovk
[3.12] bpo-14322: added test case for invalid update to hmac (GH-26636)…
6dbf85c 
… (#115904)

Co-authored-by: Arjun <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Feb 25, 2024
@miss-islington @CCLDArjun @hugovk
[3.11] bpo-14322: added test case for invalid update to hmac (GH-26636)…
c6455ff 
… (#115905)

Co-authored-by: Arjun <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@CCLDArjun @hugovk @woodruffw
bpo-14322: added test case for invalid update to hmac (python#26636)
ee6aec0 
Co-authored-by: Hugo van Kemenade <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@CCLDArjun @hugovk @diegorusso
bpo-14322: added test case for invalid update to hmac (python#26636)
576f16b 
Co-authored-by: Hugo van Kemenade <[email protected]>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@CCLDArjun @hugovk @LukasWoodtli
bpo-14322: added test case for invalid update to hmac (python#26636)
8259cd2 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CCLDArjun @hugovk @nanjekyejoannah @the-knights-who-say-ni @ezio-melotti @bedevere-bot