Skip to content

bpo-38530: Require 50% similarity in NameError suggestions #25584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2021
Merged

bpo-38530: Require 50% similarity in NameError suggestions #25584

merged 4 commits into from
Apr 27, 2021

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 25, 2021 •
edited by bedevere-bot
Loading

@isidentical
Copy link
Member

Since this is a new feature in 3.10, I don't think there is a need for a news entry.

@isidentical isidentical requested a review from pablogsal April 25, 2021 03:40
@pablogsal
Copy link
Member

Yeah, could you remove the NEWS entry, @sweeneyde? Otherwise, LGTM

pablogsal
pablogsal reviewed Apr 25, 2021
View reviewed changes
@sweeneyde sweeneyde force-pushed the bad_small_suggestions branch from efba22a to c88fd85 Compare April 25, 2021 03:58
@sweeneyde
Copy link
Member Author

A thought: MAX_DISTANCE could be made larger if this change is made.

@pablogsal
Copy link
Member

A thought: MAX_DISTANCE could be made larger if this change is made.

Indeed, do you have some bandwidth to do some investigation on this? I am referring to what could be a sensible value once we merge this PR.

@pablogsal pablogsal merged commit 284c52d into python:master Apr 27, 2021
@sweeneyde
Copy link
Member Author

A thought: MAX_DISTANCE could be made larger if this change is made.

Indeed, do you have some bandwidth to do some investigation on this? I am referring to what could be a sensible value once we merge this PR.

I can look at some other compilers/interpreters/editors/document processors within the next few days.

@pablogsal
Copy link
Member

I can look at some other compilers/interpreters/editors/document processors within the next few days.

Thanks, that would be great!

@sweeneyde sweeneyde deleted the bad_small_suggestions branch December 19, 2021 05:35
@tirkarthi tirkarthi mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sweeneyde @isidentical @pablogsal @the-knights-who-say-ni @bedevere-bot