-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-42528: Improve the docs of most Py*_Check{,Exact} API calls. #23602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think that none of these API calls can fail, but only few of them are documented as such. Add the sentence "This function always succeeds" (which is the same already used e.g. by PyNumber_Check) to all of them.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This PR is stale because it has been open for 30 days with no activity. |
The label still says "CLA not signed" but I did. What am I supposed to do? |
@antocuni can you check the CLA status here: https://check-python-cla.herokuapp.com/ It will change the label for you of the CLA has been signed. |
it worked, thank you! |
Merged, thanks @antocuni! |
GH-24139 is a backport of this pull request to the 3.9 branch. |
Sorry, @antocuni and @vstinner, I could not cleanly backport this to |
…onGH-23602) I think that none of these API calls can fail, but only few of them are documented as such. Add the sentence "This function always succeeds" (which is the same already used e.g. by PyNumber_Check) to all of them. (cherry picked from commit 315fc52) Co-authored-by: Antonio Cuni <[email protected]>
…3602) (GH-24139) I think that none of these API calls can fail, but only few of them are documented as such. Add the sentence "This function always succeeds" (which is the same already used e.g. by PyNumber_Check) to all of them. (cherry picked from commit 315fc52) Co-authored-by: Antonio Cuni <[email protected]> Co-authored-by: Antonio Cuni <[email protected]>
…onGH-23602) I think that none of these API calls can fail, but only few of them are documented as such. Add the sentence "This function always succeeds" (which is the same already used e.g. by PyNumber_Check) to all of them.
I think that none of these API calls can fail, but only few of them are
documented as such. Add the sentence "This function always succeeds" (which is
the same already used e.g. by PyNumber_Check) to all of them.
https://bugs.python.org/issue42528