Skip to content

bpo-29617: Remove Python 3.3 support from asyncio #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

methane
Copy link
Member

@methane methane commented Feb 22, 2017

@methane
Copy link
Member Author

methane commented Feb 22, 2017

tips: https://github.com/python/cpython/pull/232/files?w=1 can be used to ignore indent changes while review.

Copy link
Contributor

@deronnax deronnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I see, the "compat" import isn't used anymore in this file after your patch and can be removed

@methane
Copy link
Member Author

methane commented Feb 22, 2017

@deronnax nice catch!

@vstinner
Copy link
Member

vstinner commented Feb 22, 2017

Oh, I'm very happy to see the removal of the ugly _TracebackLogger class with its giant docstring to justify its design :-) It's also nice to see all conditional code on __del__().

@vstinner
Copy link
Member

Before approving, how do Python 3.3 users get asyncio? "python3.3 -m install asyncio" which gets https://pypi.python.org/pypi/asyncio backport? This version is no more maintained, right? (Latest release: 2015-03-10.)

The asyncio documentation (on readthedocs.io) requires 3.5 or higher!
http://asyncio.readthedocs.io/en/latest/getting_started.html#python-3-5-or-higher-only

@vstinner vstinner requested review from 1st1 and gvanrossum February 22, 2017 11:21
@methane
Copy link
Member Author

methane commented Feb 22, 2017

If PyPI package for Python 3.3 is needed, we can export code from 3.6 branch.
It means new features of Python 3.7+ are not ported to asyncio for Python 3.3.

And if asyncio on PyPI won't be updated anymore, we can remove compat module completely.

@vstinner
Copy link
Member

If PyPI package for Python 3.3 is needed, we can export code from 3.6 branch. It means new features of Python 3.7+ are not ported to asyncio for Python 3.3.

Two years ago, the policy was to use exactly the same code base on all CPython branches and on the https://github.com/python/asyncio project.

What is the current policy?

https://github.com/python/asyncio description is "This project is the asyncio module for Python 3.3". Do we still need this project? This project has 76 open issues and 12 pull requests.

1 similar comment
@vstinner
Copy link
Member

If PyPI package for Python 3.3 is needed, we can export code from 3.6 branch. It means new features of Python 3.7+ are not ported to asyncio for Python 3.3.

Two years ago, the policy was to use exactly the same code base on all CPython branches and on the https://github.com/python/asyncio project.

What is the current policy?

https://github.com/python/asyncio description is "This project is the asyncio module for Python 3.3". Do we still need this project? This project has 76 open issues and 12 pull requests.

@methane
Copy link
Member Author

methane commented Feb 22, 2017

I added @gvanrossum and @1st1 to nosy list of https://bugs.python.org/issue29617 and
waiting future plan of it.

@1st1
Copy link
Member

1st1 commented Apr 24, 2017

@methane Let's merge this!

@1st1 1st1 removed the request for review from gvanrossum April 24, 2017 17:56
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please rebase it to the latest master.

@methane methane merged commit 3e2ad8e into python:master Apr 25, 2017
@methane methane deleted the byebye-py33 branch February 12, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants