-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-29617: Remove Python 3.3 support from asyncio #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tips: https://github.com/python/cpython/pull/232/files?w=1 can be used to ignore indent changes while review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I see, the "compat" import isn't used anymore in this file after your patch and can be removed
@deronnax nice catch! |
Oh, I'm very happy to see the removal of the ugly _TracebackLogger class with its giant docstring to justify its design :-) It's also nice to see all conditional code on |
Before approving, how do Python 3.3 users get asyncio? "python3.3 -m install asyncio" which gets https://pypi.python.org/pypi/asyncio backport? This version is no more maintained, right? (Latest release: 2015-03-10.) The asyncio documentation (on readthedocs.io) requires 3.5 or higher! |
If PyPI package for Python 3.3 is needed, we can export code from 3.6 branch. And if asyncio on PyPI won't be updated anymore, we can remove |
Two years ago, the policy was to use exactly the same code base on all CPython branches and on the https://github.com/python/asyncio project. What is the current policy? https://github.com/python/asyncio description is "This project is the asyncio module for Python 3.3". Do we still need this project? This project has 76 open issues and 12 pull requests. |
1 similar comment
Two years ago, the policy was to use exactly the same code base on all CPython branches and on the https://github.com/python/asyncio project. What is the current policy? https://github.com/python/asyncio description is "This project is the asyncio module for Python 3.3". Do we still need this project? This project has 76 open issues and 12 pull requests. |
I added @gvanrossum and @1st1 to nosy list of https://bugs.python.org/issue29617 and |
@methane Let's merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please rebase it to the latest master.
Bumps [cachetools](https://github.com/tkem/cachetools) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/tkem/cachetools/releases) - [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGES.rst) - [Commits](tkem/cachetools@v3.1.0...v3.1.1)
[bpo-29617]