bpo-29591: [2.7] Update VS project files #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jun 21, 2017
| @@ -12,7 +12,7 @@ | |||
| InlineFunctionExpansion="1" | |||
| EnableIntrinsicFunctions="true" | |||
| AdditionalIncludeDirectories="..\..\Include; ..\..\PC" | |||
| PreprocessorDefinitions="_WIN32" | |||
| PreprocessorDefinitions="_WIN32;WIN32" | |||
There was a problem hiding this comment.
I'm not sure that this change is still needed with expat 2.2.1. Would you mind to check please?
There was a problem hiding this comment.
Actually this is unrelated to just Expat. It brings the VS9.0 project files inline with the MSBuild ones. Ever wonder why the Expat change "just worked" on the other releases? ;)
There was a problem hiding this comment.
Ok fine. I'm just surprised that we have to define it manualy. It should already be defined by <windows.h> no?
|
The overall change LGTM, except of my (minor) comments. Can you please rebase it since I just merged my expat 2.2.1 change? |
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
6782ae7 to
80aa260
Compare
* Silence warnings caused by duplicated defines from Modules\expat\winconfig.h * Add WIN32 define to VS9.0 project files to match MSBuild project files.
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
80aa260 to
153dfe6
Compare
|
Rebased and modified commit message. |
|
The ch1nge looks safe and should at least fix the HAVE_MEMMOVE warning. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Visual Studio project files to fix regressions due to Expat 2.2.0