Skip to content

bpo-29940: Add follow_wrapped option to help() #22390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Sep 23, 2020

When print the docstring using help builtin for an wrapper function
it doesn't correspond to the function wrapped. For avoid this
this PR add the follow_wrapped option to help() function.

This is the continuation of the wrong #12915

cc: @chrahunt @taleinat

https://bugs.python.org/issue29940

eamanu and others added 9 commits September 22, 2020 21:11
When print the docstring using help builtin for an wrapper function
it doesn't correspond to the function wrapped. For avoid this
this PR add the follow_wrapped to help().
Co-authored-by: Tal Einat <[email protected]>
@taleinat
Copy link
Contributor

It seems to me that the implementation approach here is strange, surprising, and could have unexpected consequences.

Why did you choose this rather than actually checking for wrapped, and following it (recursively) if found?

@taleinat
Copy link
Contributor

taleinat commented Sep 26, 2020

Thanks for the PR, @eamanu, but this has already been resolved by PR GH-19479, as described and discussed in bpo-40257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants