[2.7] bpo-30675: Fix refleak hunting in regrtest #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Jun 16, 2017
| @@ -438,6 +438,8 @@ def main(tests=None, testdir=None, verbose=0, quiet=False, | |||
|
|
|||
| if slaveargs is not None: | |||
| args, kwargs = json.loads(slaveargs) | |||
There was a problem hiding this comment.
Do you want to backport the slaveargs changes just backported to 3.5? Or there is no need?
There was a problem hiding this comment.
I'm not interested to backport this change. While regrtest of 3.5 is old, regrtest of 2.7 is even older. Backporting regrtest enhancements is more and more complex :-/
If we want to get more new regrtest features, I would prefer to "simply" copy regrtest from master to other branches.
Lib/test/regrtest.py
Outdated
| @@ -1418,6 +1423,18 @@ def clear_caches(): | |||
| # Collect cyclic trash. | |||
| gc.collect() | |||
|
|
|||
| def warm_caches(): | |||
| """Create explicitly internal singletons which are created on demand | |||
| to prevent false positive when hunting reference leaks (-R 3:3).""" | |||
There was a problem hiding this comment.
Just -R. It can be used with other values.
regrtest now warms up caches: create explicitly all internal singletons which are created on demand to prevent false positives when checking for reference leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regrtest now warms up caches: create explicitly all internal
singletons which are created on demand to prevent false positives
when checking for reference leaks.