Skip to content

MSVC: The ARM command line should not define MASM #21817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

MSVC: The ARM command line should not define MASM #21817

merged 1 commit into from
Aug 10, 2020

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Aug 10, 2020

The relevant part of the command lines should look as follows:

x64: /DCONFIG_64 /DMASM

Win32: /DCONFIG_32 /DPPRO /DMASM

ARM64: /DCONFIG_64 /DANSI

ARM: /DCONFIG_32 /DANSI

@skrah skrah requested a review from rhettinger as a code owner August 10, 2020 20:00
@skrah skrah requested a review from zooba August 10, 2020 20:00
@skrah
Copy link
Contributor Author

skrah commented Aug 10, 2020

The current situation is not an error: It happens to work because MASM is not activated if ANSI is defined, so we don't have to backport.

But the intent is that MASM and ANSI are mutually exclusive.

@skrah
Copy link
Contributor Author

skrah commented Aug 10, 2020

I'm editing _decimal.vcxproj by hand, but all windows buildbots pass, so it must be correct.

@skrah skrah merged commit a02efe4 into python:master Aug 10, 2020
@bedevere-bot
Copy link

@skrah: Please replace # with GH- in the commit message next time. Thanks!

@skrah skrah deleted the masm_defines branch August 10, 2020 20:44
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@skrah @shihai1991
MSVC: The ARM command line should not define MASM. (python#21817)
c7c91df
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@skrah
MSVC: The ARM command line should not define MASM. (python#21817)
5b0d4e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrah @bedevere-bot @the-knights-who-say-ni