Skip to content

bpo-40275: Use new test.support helper submodules in tests #21764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Aug 7, 2020

@shihai1991 shihai1991 changed the title bpo-40275: Use new test.support helper submodules in tests [WIP] bpo-40275: Use new test.support helper submodules in tests Aug 7, 2020
@shihai1991 shihai1991 changed the title [WIP] bpo-40275: Use new test.support helper submodules in tests bpo-40275: Use new test.support helper submodules in tests Aug 7, 2020
@shihai1991 shihai1991 force-pushed the bpo_40275_helper_replace_19 branch from ee875f9 to f592ee3 Compare August 7, 2020 12:15
@vstinner
Copy link
Member

vstinner commented Aug 7, 2020

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

  shell: /bin/bash -e {0}
Run if [ -z "GITHUB_BASE_REF" ]; then
  if [ -z "GITHUB_BASE_REF" ]; then
    echo '::set-output name=run_tests::true'
  else
    git fetch origin $GITHUB_BASE_REF --depth=1
    git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true
  fi
  shell: /bin/bash -e {0}
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
fatal: origin/master...HEAD: no merge base

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

@shihai1991
Copy link
Member Author

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

  shell: /bin/bash -e {0}
Run if [ -z "GITHUB_BASE_REF" ]; then
  if [ -z "GITHUB_BASE_REF" ]; then
    echo '::set-output name=run_tests::true'
  else
    git fetch origin $GITHUB_BASE_REF --depth=1
    git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true
  fi
  shell: /bin/bash -e {0}
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
fatal: origin/master...HEAD: no merge base

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

Oh, meet this problem again. I already open an thread in: https://discuss.python.org/t/why-the-ci-gate-in-fork-repo-has-been-disabled/4909.
Looks like nobody know the reason.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

vstinner commented Aug 7, 2020

It failed on Windows:

ERROR: setUpClass (test.test_asyncio.test_proactor_events.ProactorEventLoopUnixSockSendfileTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "d:\a\1\s\lib\test\test_asyncio\test_proactor_events.py", line 937, in setUpClass
    with open(os_helper.TESTFN, 'wb') as fp:
NameError: name 'os_helper' is not defined

@shihai1991
Copy link
Member Author

It failed on Windows:

ERROR: setUpClass (test.test_asyncio.test_proactor_events.ProactorEventLoopUnixSockSendfileTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "d:\a\1\s\lib\test\test_asyncio\test_proactor_events.py", line 937, in setUpClass
    with open(os_helper.TESTFN, 'wb') as fp:
NameError: name 'os_helper' is not defined

updated.

@vstinner
Copy link
Member

vstinner commented Aug 7, 2020

updated

Ah, maybe the GitHub UI pointed me to the wrong build. Now I see that Azure Pipelines is running again.

@shihai1991
Copy link
Member Author

updated

Ah, maybe the GitHub UI pointed me to the wrong build. Now I see that Azure Pipelines is running again.

Your are right. I have push a commit again: )

@shihai1991
Copy link
Member Author

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

  shell: /bin/bash -e {0}
Run if [ -z "GITHUB_BASE_REF" ]; then
  if [ -z "GITHUB_BASE_REF" ]; then
    echo '::set-output name=run_tests::true'
  else
    git fetch origin $GITHUB_BASE_REF --depth=1
    git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true
  fi
  shell: /bin/bash -e {0}
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
fatal: origin/master...HEAD: no merge base

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

Looks like ... in `git diff --name-only origin/$GITHUB_BASE_REF... ' is redundant(I am not sure about it).
But It is worked actually after I removed it: https://github.com/shihai1991/cpython/pull/28/files

@vstinner vstinner merged commit 598a951 into python:master Aug 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants