-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-41371: Handle lzma lib import error in test_zoneinfo.py #21734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My apologies for the possible deluge of notifications. I messed up the commit history and cleaned it up inefficiently to put it lightly. This should have the approach mentioned by vstinner on issue https://bugs.python.org/issue41476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Note, import_helper
is not present in 3.9 and hence automatic backport might fail.
I am happy to do the backport for this PR as long as my understanding is correct. According to the "Accepting Pull Requests" document, once the PR is merged, another PR should be created that backports this fix to 3.9. The backport PR title should be "[3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py" Am I understanding the process correctly? |
@nmaynes You don't have to worry about the backport, the label is a signal that triggers a bot that does it automatically on merge. |
Thanks @nmaynes for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-21758 is a backport of this pull request to the 3.9 branch. |
…-21734) (cherry picked from commit 5f0769a) Co-authored-by: Nathan M <[email protected]>
…thonGH-21734) (cherry picked from commit 5f0769a) Co-authored-by: Nathan M <[email protected]>
…-21734) (GH-22039) (cherry picked from commit 5f0769a) Co-authored-by: Nathan M <[email protected]>
https://bugs.python.org/issue41371
Automerge-Triggered-By: @pganssle