Skip to content

bpo-41371: Handle lzma lib import error in test_zoneinfo.py #21734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

nmaynes
Copy link
Contributor

@nmaynes nmaynes commented Aug 4, 2020

@nmaynes
Copy link
Contributor Author

nmaynes commented Aug 4, 2020

My apologies for the possible deluge of notifications. I messed up the commit history and cleaned it up inefficiently to put it lightly. This should have the approach mentioned by vstinner on issue https://bugs.python.org/issue41476

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Note, import_helper is not present in 3.9 and hence automatic backport might fail.

@nmaynes
Copy link
Contributor Author

nmaynes commented Aug 6, 2020

I am happy to do the backport for this PR as long as my understanding is correct. According to the "Accepting Pull Requests" document, once the PR is merged, another PR should be created that backports this fix to 3.9. The backport PR title should be "[3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py" Am I understanding the process correctly?

@pganssle
Copy link
Member

pganssle commented Aug 6, 2020

@nmaynes You don't have to worry about the backport, the label is a signal that triggers a bot that does it automatically on merge.

@miss-islington miss-islington merged commit 5f0769a into python:master Aug 6, 2020
@miss-islington
Copy link
Contributor

Thanks @nmaynes for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-21758 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2020
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 6, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Sep 1, 2020
tirkarthi added a commit that referenced this pull request Oct 10, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants