Skip to content

[RFC] inspect: BlockFinder: handle nested parens with decorators #21425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC] inspect: BlockFinder: handle nested parens with decorators #21425

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 9, 2020 •
edited
Loading

Fixes:

import inspect

def deco(*args, **kwargs):
    def wrapped(f):
        return f
    return wrapped

@deco((lambda: True), (lambda: False))
def func():
    pass

print(inspect.getsource(func))

Without this patch it would only print:

@deco((lambda: True), (lambda: False))

TODO:

Related: #17374

@blueyed
inspect: BlockFinder: handle nested parens with decorators
9fc3c7a 
Fixes:
```
import inspect

def deco(*args, **kwargs):
    def wrapped(f):
        return f
    return wrapped

@Deco((lambda: True), (lambda: False))
def func():
    pass

print(inspect.getsource(func))
```

Without this patch it would only print:

> @Deco((lambda: True), (lambda: False))
@blueyed blueyed mentioned this pull request Jul 9, 2020
Closed
@blueyed blueyed changed the title inspect: BlockFinder: handle nested parens with decorators [RFC] inspect: BlockFinder: handle nested parens with decorators Jul 9, 2020
@Deco
Copy link

Deco commented Jul 10, 2020

@blueyed You called?

@ahopkins ahopkins mentioned this pull request Feb 28, 2022
Closed
@ahopkins
Copy link

Still an issue in need of merge. I opened a similar PR before finding this one.

#31605

iritkatriel
iritkatriel requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a unit test and news item.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AlexWaygood
Copy link
Member

@carljm, am I correct in thinking this has been superseded by #99654?

@carljm
Copy link
Member

carljm commented Dec 7, 2022

Yep, superseded.

@carljm carljm closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

@kk456852 kk456852 kk456852 approved these changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@blueyed @Deco @ahopkins @bedevere-bot @AlexWaygood @carljm @iritkatriel @kk456852 @the-knights-who-say-ni @ezio-melotti