-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-28681: Clarify multiple function names in the tutorial #21340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the addition of 'also' to the part I wrote. Re-reading, I find it a bit jarring without the addition. Thank you for attending to this.
When you're done making the requested changes, leave the comment: |
Co-authored-by: Terry Jan Reedy <[email protected]>
Guido strongly prefers and the devguide now clearly states that the first message line of a merged commit should be an active tense statement, like the first line of docstrings. (I would say "Should start with an active verb" except that there might be a short introductory phrase.) This is easier to ensure if the default, the PR title, is written that way. Hence my edit. |
Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <[email protected]>
GH-21343 is a backport of this pull request to the 3.9 branch. |
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <[email protected]>
Thanks for the review @terryjreedy |
GH-21344 is a backport of this pull request to the 3.8 branch. |
…GH-21343) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <[email protected]> Co-authored-by: Joannah Nanjekye <[email protected]>
…GH-21344) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <[email protected]> Co-authored-by: Joannah Nanjekye <[email protected]>
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
Merged ideas from @bitdancer and @terryjreedy in the bpo thread.
https://bugs.python.org/issue28681