Skip to content

bpo-41204: Fix compiler warning in ast_type_init() #21307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2020
Merged

bpo-41204: Fix compiler warning in ast_type_init() #21307

merged 1 commit into from
Jul 4, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 3, 2020 •
edited by bedevere-bot
Loading

@vstinner vstinner merged commit 1f76453 into python:master Jul 4, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1f76453173267887ed05bb3783e862cb22365ae8 3.9

@vstinner
Copy link
Member Author

vstinner commented Jul 4, 2020

Thanks for reviews @isidentical and @corona10 :-)

@vstinner vstinner deleted the fix_ast_warn branch July 4, 2020 21:18
@vstinner vstinner removed the needs backport to 3.9 only security fixes label Jul 4, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jul 6, 2020
@vstinner @shihai1991
bpo-41204: Fix compiler warning in ast_type_init() (pythonGH-21307)
b51f3ca
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vstinner @arun-mani-j
bpo-41204: Fix compiler warning in ast_type_init() (pythonGH-21307)
28e9fef
vstinner added a commit that referenced this pull request Aug 10, 2020
@vstinner
[3.9] bpo-41194: Convert _ast extension to PEP 489 (GH-21807)
d2bea26 
* bpo-41194: Convert _ast extension to PEP 489 (GH-21293)

Convert the _ast extension module to PEP 489 "Multiphase
initialization". Replace the global _ast state with a module state.

(cherry picked from commit b1cc6ba)

* bpo-41204: Fix compiler warning in ast_type_init() (GH-21307)

(cherry picked from commit 1f76453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@isidentical isidentical isidentical approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstinner @miss-islington @corona10 @isidentical @the-knights-who-say-ni @bedevere-bot