Skip to content

bpo-41005: Fixed perrmission error #20936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2020
Merged

bpo-41005: Fixed perrmission error #20936

merged 4 commits into from
Jun 22, 2020

Conversation

KrishnaSai2020
Copy link
Contributor

@KrishnaSai2020 KrishnaSai2020 commented Jun 17, 2020 •
edited by bedevere-bot
Loading

bpo-41005: Fixed if/else bug in code

https://bugs.python.org/issue41005

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@KrishnaSai2020

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@KrishnaSai2020 KrishnaSai2020 changed the title bpo-41005: Fixeed if/else bug in code bpo-41005: Fixed if/else bug in code Jun 17, 2020
@KrishnaSai2020
Copy link
Contributor Author

I've signed the CLA but it will take one business day to come through should I close this pull request and create new one once the cla goes through??

@remilapeyre
Copy link
Contributor

I've signed the CLA but it will take one business day to come through should I close this pull request and create new one once the cla goes through??

Hi @KrishnaSai2020, welcome to Python! You can wait a few days and use https://check-python-cla.herokuapp.com/ to check the CLA again.

@KrishnaSai2020
Copy link
Contributor Author

@remilapeyre ok then will do 👍

@KrishnaSai2020
Copy link
Contributor Author

@remilapeyre yeah its come through please review

@KrishnaSai2020
Copy link
Contributor Author

@remilapeyre please review

ronaldoussoren
ronaldoussoren requested changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is not the correct fix, this just removes the xdg-settings path on macOS, event without changing the comment in the macOS specific path that says macOS also uses the unix behaviour.

A better fix is to catch and ignore PermissionError when starting xdg-settings (not being allowed to start xdg-settings is similar to it not being on the system at all)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@KrishnaSai2020
Copy link
Contributor Author

KrishnaSai2020 commented Jun 21, 2020 •
edited
Loading

@ronaldoussoren so you're suggesting a try except block to catch the permissions error? also how could code it to ignore the error?

edit : wait no I could just type pass

@KrishnaSai2020
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ronaldoussoren: please review the changes made to this pull request.

@KrishnaSai2020 KrishnaSai2020 changed the title bpo-41005: Fixed if/else bug in code bpo-41005: Fixed perrmission error Jun 21, 2020
@KrishnaSai2020
Copy link
Contributor Author

@ronaldoussoren please re-review the changes that were made

ronaldoussoren
ronaldoussoren approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@ronaldoussoren ronaldoussoren merged commit 9e27bc0 into python:master Jun 22, 2020
@miss-islington
Copy link
Contributor

Thanks @KrishnaSai2020 for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2020
@KrishnaSai2020 @miss-islington
bpo-41005: Fixed perrmission error (pythonGH-20936)
55a0b3c 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 9e27bc0)

Co-authored-by: Krishna Chivukula <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 22, 2020
@bedevere-bot
Copy link

GH-21051 is a backport of this pull request to the 3.9 branch.

@ronaldoussoren
Copy link
Contributor

@KrishnaSai2020: Thanks for your PR!

@bedevere-bot
Copy link

GH-21052 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2020
@KrishnaSai2020 @miss-islington
bpo-41005: Fixed perrmission error (pythonGH-20936)
f51577e 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 9e27bc0)

Co-authored-by: Krishna Chivukula <[email protected]>
@KrishnaSai2020
Copy link
Contributor Author

@ronaldoussoren np!

ronaldoussoren pushed a commit that referenced this pull request Jun 24, 2020
@miss-islington @KrishnaSai2020
bpo-41005: Fixed perrmission error (GH-20936) (GH-21052)
adf8708 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 9e27bc0)

Co-authored-by: Krishna Chivukula <[email protected]>

Co-authored-by: Krishna Chivukula <[email protected]>
ronaldoussoren pushed a commit that referenced this pull request Jun 24, 2020
@miss-islington @KrishnaSai2020
bpo-41005: Fixed perrmission error (GH-20936) (GH-21051)
d518ed0 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 9e27bc0)

Co-authored-by: Krishna Chivukula <[email protected]>

Co-authored-by: Krishna Chivukula <[email protected]>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@KrishnaSai2020 @blurb-it @fasihahmad
bpo-41005: Fixed perrmission error (pythonGH-20936)
3fbe16b 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@KrishnaSai2020 @blurb-it @arun-mani-j
bpo-41005: Fixed perrmission error (pythonGH-20936)
8273ccf 
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed

Co-authored-by: KrishnaSai2020 <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@KrishnaSai2020 KrishnaSai2020 deleted the fix-issue-41005 branch July 24, 2021 12:56
@krishnasai2020 krishnasai2020 mannequin mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KrishnaSai2020 @the-knights-who-say-ni @remilapeyre @bedevere-bot @miss-islington @ronaldoussoren